Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations v2 #1040

Merged
merged 4 commits into from Sep 8, 2023
Merged

Recommendations v2 #1040

merged 4 commits into from Sep 8, 2023

Conversation

zainab-amir
Copy link
Contributor

@zainab-amir zainab-amir commented Aug 21, 2023

Description

  • Get launch ready for 100% users.
  • These recommendations will include both static and personalized recommendations.
    • For static, we will be displaying Popular and Trending products.
    • For personalized, we will be quering Algolia
      • If Algolia is recommendations are skipped, only static are shown.

JIRA

VAN-1597

How Has This Been Tested?

Locally and by adding new tests

Screenshots/sandbox (optional):

Screenshot 2023-08-21 at 12 23 25 PM

@zainab-amir zainab-amir marked this pull request as ready for review August 21, 2023 07:19
@zainab-amir zainab-amir requested a review from a team as a code owner August 21, 2023 07:19
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 94.24% and project coverage change: +1.69% 🎉

Comparison is base (37e811d) 85.29% compared to head (6c45180) 86.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1040      +/-   ##
==========================================
+ Coverage   85.29%   86.99%   +1.69%     
==========================================
  Files         118      124       +6     
  Lines        2204     2269      +65     
  Branches      611      626      +15     
==========================================
+ Hits         1880     1974      +94     
+ Misses        310      286      -24     
+ Partials       14        9       -5     
Files Changed Coverage Δ
src/config/index.js 0.00% <0.00%> (ø)
src/recommendations/ProductCard/index.jsx 79.41% <ø> (+5.88%) ⬆️
src/recommendations/messages.js 100.00% <ø> (ø)
src/progressive-profiling/ProgressiveProfiling.jsx 94.68% <71.42%> (-2.20%) ⬇️
...dations/RecommendationsPageLayouts/LargeLayout.jsx 90.00% <90.00%> (ø)
...dations/RecommendationsPageLayouts/SmallLayout.jsx 90.00% <90.00%> (ø)
src/recommendations/RecommendationsPage.jsx 91.89% <95.23%> (+5.68%) ⬆️
src/data/algolia.js 100.00% <100.00%> (ø)
src/data/oneTrust.js 100.00% <100.00%> (ø)
src/recommendations/ProductCard/BaseCard/index.jsx 100.00% <100.00%> (+20.00%) ⬆️
... and 8 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zainab-amir
Copy link
Contributor Author

zainab-amir commented Sep 7, 2023

We will not be showing static recommendations anymore. See https://2u-internal.atlassian.net/browse/VAN-1652 for more details.

Large Medium Small
Screenshot 2023-09-07 at 12 15 36 AM Screenshot 2023-09-07 at 12 15 58 AM Screenshot 2023-09-07 at 12 16 23 AM

@syedsajjadkazmii
Copy link
Contributor

Please fix tests

syedsajjadkazmii and others added 4 commits September 7, 2023 14:27
* use Algolia for personalized recommendations
* show personalized recommendations to use that have consented
to functional cookies
* update tests

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (#1029)" (#1030)

This reverts commit fc62241.
@syedsajjadkazmii syedsajjadkazmii merged commit 5e15969 into master Sep 8, 2023
7 checks passed
@syedsajjadkazmii syedsajjadkazmii deleted the recommendations-v2 branch September 8, 2023 07:08
snglth pushed a commit to Abstract-Tech/community-theme-authn that referenced this pull request Jan 9, 2024
* feat: add personalized recommendations (openedx#1024)

* use Algolia for personalized recommendations
* show personalized recommendations to use that have consented
to functional cookies
* update tests

VAN-1599

* Revert "fix: special characters in redirect url getting decoded to space (openedx#1029)" (openedx#1030)

This reverts commit fc62241.

* feat: update recommendations page design (openedx#1036)

VAN-1598

* feat: add events for recommendations (openedx#1039)

* feat: remove static recommendations

---------

Co-authored-by: Syed Sajjad Hussain Shah <52817156+syedsajjadkazmii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants